cleanup(core): move a few api points to return root maps directly #22949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c648e91. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
cleanup/root-map-apis
branch
2 times, most recently
from
de51a22
to
5aa9f39
Compare
FrozenPandaz
requested changes
Apr 22, 2024
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
| // | ||
| // The signature itself can't be changed as we need it to return | ||
| // project configurations for use in devkit. | ||
| readProjectConfigurationsFromRootMap(projectRootMap); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
We still use the function in 2-3 other places to read the configs, so I don't think we'd change it
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
AgentEnder
force-pushed
the
cleanup/root-map-apis
branch
6 times, most recently
from
1498060
to
244973d
Compare
4 tasks
AgentEnder
force-pushed
the
cleanup/root-map-apis
branch
2 times, most recently
from
58c8668
to
909fd23
Compare
AgentEnder
force-pushed
the
cleanup/root-map-apis
branch
from
909fd23
to
c648e91
Compare
FrozenPandaz
approved these changes
Apr 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 355d5c5)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
retrieveProjectConfigurations returns a Record<name, config>
Expected Behavior
retrieveProjectConfigurations returns a Record<root, config>
Related Issue(s)
Fixes #